Allow nested JSON structures in metadata#14
Merged
Merged
Conversation
The MetadataDict type was overly restrictive, only allowing flat scalar values (dict[str, MetadataValue]). This prevented storing nested objects and arrays despite extensive documentation claiming these features were supported. Changed MetadataDict from dict[str, MetadataValue] to dict[str, JsonValue], which supports recursive nested structures including objects, arrays, and mixed types. This aligns the implementation with documentation and enables all documented use cases. Changes: - app/types.py: Updated MetadataDict to use JsonValue for nested support - app/models.py: Removed duplicate MetadataDict definition, import from types Backward compatible: All existing flat metadata structures continue working.
Added extensive test coverage for nested JSON structures in metadata to validate the fix allowing nested objects and arrays. Tests cover: - Deeply nested objects (3-4 levels) - Arrays with mixed types - Nested path queries with dot notation - Complex real-world scenarios - Metadata preservation across store/retrieve cycles All tests verify that nested structures are correctly stored, retrieved, and queryable as documented.
Added 5 comprehensive integration tests validating nested JSON support: - Complex nested objects (4 levels deep) - Array storage with mixed types - Deep nesting validation (7 levels) - Mixed nested structures (objects + arrays) - Backward compatibility with flat metadata All tests use proper pytest fixtures and async patterns. Tests verify that nested structures are correctly stored, retrieved, and preserved through the full storage lifecycle.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.